Makes TGUI transfer over when changing bodies #5388
Conversation
|
Noticed that before, I think this should just flat out be in transfer_to. Even NanoUI has UI transfer already there, it just never was done for TGUI, unless there's some obscure reason it doesn't work... |
It probably would be better to try that instead, although I'm not sure how I could check for an open tacmap from |
|
Could hook COMSIG_MOB_NEW_MIND |
This reverts commit 1bd78fe.
Using the `COMSIG_MIND_TRANSFERRED` signal here (stolen from TG of course) rather than `COMSIG_MOB_NEW_MIND` so that the UI doesn't need to unregister from the old body and re-register with the new one.
SabreML
changed the title
|
I've rewritten the PR in the latest commit with your suggestions since they made a lot of sense, and from some more testing it all seems to be working the same. (The failed checks are from a github server error) |
About the pull request
Makes any open TGUI windows transfer over when a player's mind is transferred to a new body. (At least if it's done through
/datum/mind/proc/transfer_to())This is mainly useful for xeno players who want to evolve, since it means they won't need to re-open any interfaces they had open.
The changes in
code/controllers/subsystem/minimap.dmare there so that the tacmap image remains visible to the player after a transfer, since the client changing bodies seems to remove it from theirscreenlist.(This could have hidden side effects of interfaces staying open when they shouldn't, so I'd appreciate this being testmerged for a bit just in case.)
Explain why it's good for the game
QOL addition so that you don't have to manually re-open them yourself.
Testing Photographs and Procedure
Screenshots & Videos
dreamseeker_VeVGT1te1q-output.mp4
Changelog
🆑
qol: Made open TGUI windows transfer over when a xeno player evolves.
/:cl: